{
	"issue": {
		"url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
		"repository_url": "https://api.github.com/repos/laurent22/joplin",
		"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7772/labels{/name}",
		"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7772/comments",
		"events_url": "https://api.github.com/repos/laurent22/joplin/issues/7772/events",
		"html_url": "https://github.com/laurent22/joplin/pull/7772",
		"id": 1584688078,
		"node_id": "PR_kwDOBLftOs5J-PnC",
		"number": 7772,
		"title": "Android: Fixes #7766: Updated foreground and monochrome icon to the vector drawable",
		"user": {
			"login": "fobo66",
			"id": 4471821,
			"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
			"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
			"gravatar_id": "",
			"url": "https://api.github.com/users/fobo66",
			"html_url": "https://github.com/fobo66",
			"followers_url": "https://api.github.com/users/fobo66/followers",
			"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
			"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
			"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
			"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
			"organizations_url": "https://api.github.com/users/fobo66/orgs",
			"repos_url": "https://api.github.com/users/fobo66/repos",
			"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
			"received_events_url": "https://api.github.com/users/fobo66/received_events",
			"type": "User",
			"user_view_type": "public",
			"site_admin": false
		},
		"labels": [
			{
				"id": 1366672041,
				"node_id": "MDU6TGFiZWwxMzY2NjcyMDQx",
				"url": "https://api.github.com/repos/laurent22/joplin/labels/android",
				"name": "android",
				"color": "bfd4f2",
				"default": false,
				"description": ""
			}
		],
		"state": "closed",
		"locked": false,
		"assignee": null,
		"assignees": [],
		"milestone": null,
		"comments": 40,
		"created_at": "2023-02-14T19:10:19Z",
		"updated_at": "2023-06-05T16:12:21Z",
		"closed_at": "2023-05-29T10:36:47Z",
		"author_association": "CONTRIBUTOR",
		"sub_issues_summary": {
			"total": 0,
			"completed": 0,
			"percent_completed": 0
		},
		"active_lock_reason": null,
		"draft": false,
		"pull_request": {
			"url": "https://api.github.com/repos/laurent22/joplin/pulls/7772",
			"html_url": "https://github.com/laurent22/joplin/pull/7772",
			"diff_url": "https://github.com/laurent22/joplin/pull/7772.diff",
			"patch_url": "https://github.com/laurent22/joplin/pull/7772.patch",
			"merged_at": "2023-05-29T10:36:47Z"
		},
		"body": "<!--\r\n\r\nPlease prefix the title with the platform you are targetting:\r\n\r\nHere are some examples of good titles:\r\n\r\n- Desktop: Resolves #123: Added new setting to change font\r\n- Mobile, Desktop: Fixes #456: Fixed config screen error\r\n- All: Resolves #777: Made synchronisation faster\r\n\r\nAnd here's an explanation of the title format:\r\n\r\n- \"Desktop\" for the Windows/macOS/Linux app (Electron app)\r\n- \"Mobile\" for the mobile app (or \"Android\" / \"iOS\" if the pull request only applies to one of the mobile platforms)\r\n- \"CLI\" for the CLI app\r\n\r\nIf it's two platforms, separate them with commas - \"Desktop, Mobile\" or if it's for all platforms, prefix with \"All\".\r\n\r\nIf it's not related to any platform (such as a translation, change to the documentation, etc.), simply don't add a platform.\r\n\r\nThen please append the issue that you've addressed or fixed. Use \"Resolves #123\" for new features or improvements and \"Fixes #123\" for bug fixes.\r\n\r\nAND PLEASE READ THE GUIDE: https://github.com/laurent22/joplin/blob/dev/CONTRIBUTING.md\r\n\r\n-->\r\nI've replaced the foreground and monochrome icons with the vector drawable instead of raster image, so Android can properly apply color palette to the icon.\r\n\r\nFixes #7766 \r\n",
		"closed_by": {
			"login": "laurent22",
			"id": 1285584,
			"node_id": "MDQ6VXNlcjEyODU1ODQ=",
			"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
			"gravatar_id": "",
			"url": "https://api.github.com/users/laurent22",
			"html_url": "https://github.com/laurent22",
			"followers_url": "https://api.github.com/users/laurent22/followers",
			"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
			"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
			"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
			"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
			"organizations_url": "https://api.github.com/users/laurent22/orgs",
			"repos_url": "https://api.github.com/users/laurent22/repos",
			"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
			"received_events_url": "https://api.github.com/users/laurent22/received_events",
			"type": "User",
			"user_view_type": "public",
			"site_admin": false
		},
		"reactions": {
			"url": "https://api.github.com/repos/laurent22/joplin/issues/7772/reactions",
			"total_count": 0,
			"+1": 0,
			"-1": 0,
			"laugh": 0,
			"hooray": 0,
			"confused": 0,
			"heart": 0,
			"rocket": 0,
			"eyes": 0
		},
		"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7772/timeline",
		"performed_via_github_app": null,
		"state_reason": null
	},
	"comments": [
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1430247954",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1430247954",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1430247954,
			"node_id": "IC_kwDOBLftOs5VP9oS",
			"user": {
				"login": "github-actions[bot]",
				"id": 41898282,
				"node_id": "MDM6Qm90NDE4OTgyODI=",
				"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/github-actions%5Bbot%5D",
				"html_url": "https://github.com/apps/github-actions",
				"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
				"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
				"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
				"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
				"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
				"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
				"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
				"type": "Bot",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-14T19:10:35Z",
			"updated_at": "2023-05-05T08:13:18Z",
			"author_association": "CONTRIBUTOR",
			"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA  ✍️ ✅",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1430247954/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1430250175",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1430250175",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1430250175,
			"node_id": "IC_kwDOBLftOs5VP-K_",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-14T19:12:30Z",
			"updated_at": "2023-02-14T19:12:30Z",
			"author_association": "CONTRIBUTOR",
			"body": "I have read the CLA Document and I hereby sign the CLA",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1430250175/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1432072469",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1432072469",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1432072469,
			"node_id": "IC_kwDOBLftOs5VW7EV",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-15T21:39:41Z",
			"updated_at": "2023-02-15T21:39:41Z",
			"author_association": "OWNER",
			"body": "recheck",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1432072469/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1434651411",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1434651411",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1434651411,
			"node_id": "IC_kwDOBLftOs5VgwsT",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-17T13:28:03Z",
			"updated_at": "2023-02-17T13:28:03Z",
			"author_association": "OWNER",
			"body": "Have you tried on emulator and could you post a screenshot of how it looks please? Also could you double-check that the notification icon appears properly when setting an alarm on a note?",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1434651411/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1435148823",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1435148823",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1435148823,
			"node_id": "IC_kwDOBLftOs5ViqIX",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-17T19:41:48Z",
			"updated_at": "2023-02-17T19:41:48Z",
			"author_association": "CONTRIBUTOR",
			"body": "Here are the screenshots:\r\n\r\nHomescreen icon:\r\n\r\n![Screenshot_20230217_212108](https://user-images.githubusercontent.com/4471821/219768203-831d04e6-0999-4192-b610-70e1236abc0b.png)\r\n\r\nApp drawer icon:\r\n\r\n![Screenshot_20230217_212045](https://user-images.githubusercontent.com/4471821/219768208-0211242e-0293-444d-8396-0251ce1cf508.png)\r\n\r\nTrying to set things up to show an alert to check its icon",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1435148823/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1435170504",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1435170504",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1435170504,
			"node_id": "IC_kwDOBLftOs5VivbI",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-17T19:58:39Z",
			"updated_at": "2023-02-17T20:02:59Z",
			"author_association": "CONTRIBUTOR",
			"body": "To improve compatibility, I decided to generate a new icon for the notification, based on Joplin letter, instead of using foreground icon (vector foreground icon may not work on older Android versions)",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1435170504/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1435708714",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1435708714",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1435708714,
			"node_id": "IC_kwDOBLftOs5Vky0q",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-18T16:14:59Z",
			"updated_at": "2023-02-18T16:14:59Z",
			"author_association": "CONTRIBUTOR",
			"body": "Unfortunately, I cannot run the app on the emulator for some reason to check the notification icon, it doesn't see the Metro. I tried multiple ways to run the app, but it's just doesn't work.\r\n\r\nHere's the crash that happens in the console:\r\n\r\n```\r\nFATAL EXCEPTION: OkHttp Dispatcher\r\n\r\nProcess: net.cozic.joplin, PID: 6224\r\n\r\njava.lang.NullPointerException: Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference\r\n                                                                                                    \tat java.util.regex.Matcher.reset(Matcher.java:256)\r\n                                                                                                    \tat java.util.regex.Matcher.<init>(Matcher.java:167)\r\n                                                                                                    \tat java.util.regex.Pattern.matcher(Pattern.java:1040)\r\n                                                                                                    \tat com.facebook.react.devsupport.BundleDownloader$1.onResponse(BundleDownloader.java:144)\r\n                                                                                                    \tat okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519)\r\n                                                                                                    \tat java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)\r\n                                                                                                    \tat java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)\r\n                                                                                                    \tat java.lang.Thread.run(Thread.java:1012)\r\n```\r\n\r\nAnd here's the screenshot, just in case:\r\n\r\n\r\n<img width=\"1552\" alt=\"Screenshot 2023-02-18 at 18 04 14\" src=\"https://user-images.githubusercontent.com/4471821/219876271-9a9439d4-576b-4c70-a800-ff8fc58ca436.png\">\r\n\r\nSame situation on macOS and Windows 11.\r\n\r\n",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1435708714/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1435735266",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1435735266",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1435735266,
			"node_id": "IC_kwDOBLftOs5Vk5Ti",
			"user": {
				"login": "personalizedrefrigerator",
				"id": 46334387,
				"node_id": "MDQ6VXNlcjQ2MzM0Mzg3",
				"avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/personalizedrefrigerator",
				"html_url": "https://github.com/personalizedrefrigerator",
				"followers_url": "https://api.github.com/users/personalizedrefrigerator/followers",
				"following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}",
				"gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions",
				"organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs",
				"repos_url": "https://api.github.com/users/personalizedrefrigerator/repos",
				"events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}",
				"received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-18T18:33:07Z",
			"updated_at": "2023-02-18T18:41:46Z",
			"author_association": "COLLABORATOR",
			"body": "If you haven't already, please try running `adb reverse tcp:8081 tcp:8081` (see the suggestion in the screenshot).\r\n\r\n<strike>If this doesn't work, you could try running a release build (click on \"Build Variants\" on the left side of the screen, and switch \":app\" from \"debug\" to \"release\").</strike> **Edit**: This isn't working for me. It looks like React Native release builds expect to be signed...",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1435735266/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1435988683",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1435988683",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1435988683,
			"node_id": "IC_kwDOBLftOs5Vl3LL",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-19T13:24:15Z",
			"updated_at": "2023-02-19T13:24:56Z",
			"author_association": "CONTRIBUTOR",
			"body": "It worked on Windows, but not on macOS. Although notifications seem to be broken: I can see this crash in the logcat:\r\n\r\n```\r\nFailed to send notification\r\njava.lang.IllegalArgumentException: net.cozic.joplin: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.\r\n\r\nStrongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.\r\n                                                                                                    \tat android.app.PendingIntent.checkPendingIntent(PendingIntent.java:413)\r\n                                                                                                    \tat android.app.PendingIntent.getActivityAsUser(PendingIntent.java:530)\r\n                                                                                                    \tat android.app.PendingIntent.getActivity(PendingIntent.java:516)\r\n                                                                                                    \tat android.app.PendingIntent.getActivity(PendingIntent.java:480)\r\n                                                                                                    \tat com.emekalites.react.alarm.notification.AlarmUtil.sendNotification(AlarmUtil.java:332)\r\n                                                                                                    \tat com.emekalites.react.alarm.notification.AlarmReceiver.onReceive(AlarmReceiver.java:27)\r\n                                                                                                    \tat android.app.ActivityThread.handleReceiver(ActivityThread.java:4365)\r\n                                                                                                    \tat android.app.ActivityThread.-$$Nest$mhandleReceiver(Unknown Source:0)\r\n                                                                                                    \tat android.app.ActivityThread$H.handleMessage(ActivityThread.java:2205)\r\n                                                                                                    \tat android.os.Handler.dispatchMessage(Handler.java:106)\r\n                                                                                                    \tat android.os.Looper.loopOnce(Looper.java:205)\r\n                                                                                                    \tat android.os.Looper.loop(Looper.java:294)\r\n                                                                                                    \tat android.app.ActivityThread.main(ActivityThread.java:8052)\r\n                                                                                                    \tat java.lang.reflect.Method.invoke(Native Method)\r\n                                                                                                    \tat com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:578)\r\n                                                                                                    \tat com.android.internal.os.ZygoteInit.main(ZygoteInit.java:946)\r\n```\r\n\r\nThis looks like a separate issue, easily fixable though",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1435988683/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1435999525",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1435999525",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1435999525,
			"node_id": "IC_kwDOBLftOs5Vl50l",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-19T14:09:08Z",
			"updated_at": "2023-02-19T14:09:08Z",
			"author_association": "OWNER",
			"body": "I thought I had fixed this. Is that from the last dev commit? Or alternatively would you know what is wrong and how to fix it?",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1435999525/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1436002783",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1436002783",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1436002783,
			"node_id": "IC_kwDOBLftOs5Vl6nf",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-19T14:23:32Z",
			"updated_at": "2023-02-19T14:23:32Z",
			"author_association": "CONTRIBUTOR",
			"body": "I found the issue and fixed it, along with some warnings.\r\n\r\nHere are the screenshots of the notification icon:\r\n\r\n![Screenshot_20230219_160753](https://user-images.githubusercontent.com/4471821/219954247-fb0dfc85-632d-4de7-868e-4cdcbeab49b7.png)\r\n![Screenshot_20230219_160809](https://user-images.githubusercontent.com/4471821/219954248-8ee58f47-eb41-47c8-9b5c-35674173e3c4.png)\r\n![Screenshot_20230219_160847](https://user-images.githubusercontent.com/4471821/219954249-e65635a7-ed3b-47fe-8dcb-75444bb56d5a.png)\r\n",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1436002783/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1437032397",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1437032397",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1437032397,
			"node_id": "IC_kwDOBLftOs5Vp1_N",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-20T13:32:22Z",
			"updated_at": "2023-02-20T13:32:22Z",
			"author_association": "OWNER",
			"body": "Thanks @fobo66. The icon blue background in that screenshot is not the correct Joplin blue, or is that something specific to your device? What colour would it be by default?\r\n\r\nAlso, for the notification icon, isn't it possible to revert the white/transparent color? So that we have a J instead a white background, instead of a white floating J? ",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1437032397/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1437034802",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1437034802",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1437034802,
			"node_id": "IC_kwDOBLftOs5Vp2ky",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-20T13:34:33Z",
			"updated_at": "2023-02-20T13:34:33Z",
			"author_association": "OWNER",
			"body": "Another thing is that we normally create such images from generate-images.ts. So that we don't have a thousand files to update if we want to change the icon or logo. Would you be able to add this to the logic?",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1437034802/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1437043559",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1437043559",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1437043559,
			"node_id": "IC_kwDOBLftOs5Vp4tn",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-20T13:40:50Z",
			"updated_at": "2023-02-20T13:40:50Z",
			"author_association": "CONTRIBUTOR",
			"body": "> The icon blue background in that screenshot is not the correct Joplin blue, or is that something specific to your device? What colour would it be by default?\r\n\r\nThis color is set as just `blue` in code, and this is what it gets parsed into. If we pass a correct HEX value for the color, it will be parsed and applied. Do we have a HEX somewhere for this?\r\n\r\n> Also, for the notification icon, isn't it possible to revert the white/transparent color? So that we have a J instead a white background, instead of a white floating J?\r\n\r\nI believe it depends on ROM. On some devices, the icon is tinted, others will apply the color to the icon's background. The best we can do is to set a desired color for the notification, its actual style will depend on the ROM implementation.\r\n\r\n> Another thing is that we normally create such images from generate-images.ts. So that we don't have a thousand files to update if we want to change the icon or logo. Would you be able to add this to the logic?\r\n\r\nThanks for the suggestion, will look into it\r\n",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1437043559/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1437061539",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1437061539",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1437061539,
			"node_id": "IC_kwDOBLftOs5Vp9Gj",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-20T13:56:05Z",
			"updated_at": "2023-02-20T13:56:40Z",
			"author_association": "OWNER",
			"body": "> > Another thing is that we normally create such images from generate-images.ts. So that we don't have a thousand files to update if we want to change the icon or logo. Would you be able to add this to the logic?\r\n> \r\n> Thanks for the suggestion, will look into it\r\n\r\nThanks, the idea is that we have a number of source files which are then copied in various places, and in some cases resized. If you need any help getting that working let me know.\r\n\r\n> This color is set as just blue in code, and this is what it gets parsed into. If we pass a correct HEX value for the color, it will be parsed and applied. Do we have a HEX somewhere for this?\r\n\r\nYes please, could you use `#1377da`?\r\n\r\n> I believe it depends on ROM. On some devices, the icon is tinted, others will apply the color to the icon's background. The best we can do is to set a desired color for the notification, its actual style will depend on the ROM implementation.\r\n\r\nWhat I mean is to flip the transparent and white colour, so that the icon is more visible, like in the attached file. Would you be able to use this as notification icon?\r\n\r\nEdit: It's a transparent J on a white background, so it might not be visible here but it's there\r\n\r\n![JoplinNotification](https://user-images.githubusercontent.com/1285584/220126807-f2e53bb0-dc50-45f8-aea6-c5384283f5e6.png)\r\n",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1437061539/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1437513546",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1437513546",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1437513546,
			"node_id": "IC_kwDOBLftOs5VrrdK",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-20T20:25:38Z",
			"updated_at": "2023-02-20T20:40:30Z",
			"author_association": "CONTRIBUTOR",
			"body": "Well, I've set a correct color, but RN doesn't seem to reload `AlarmServiceDriver` class on changes, for some reason it always uses the file before changes, thus icon color is always `blue`, and icon is `ic_launcher_foreground`, even if it was changed days ago. I disabled Fast Refresh, reinstalled the app, restarted emulator, restarted PC, still nothing. Maybe you have some clues what's going on?",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1437513546/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1437590769",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1437590769",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1437590769,
			"node_id": "IC_kwDOBLftOs5Vr-Tx",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-20T21:50:48Z",
			"updated_at": "2023-02-20T21:50:48Z",
			"author_association": "OWNER",
			"body": "Did you try rebuilding with `./gradlew installDebug`?",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1437590769/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1438108278",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1438108278",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1438108278,
			"node_id": "IC_kwDOBLftOs5Vt8p2",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-21T09:06:11Z",
			"updated_at": "2023-02-21T09:06:11Z",
			"author_association": "CONTRIBUTOR",
			"body": "Yes",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1438108278/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445063390",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1445063390",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1445063390,
			"node_id": "IC_kwDOBLftOs5WIere",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-25T11:47:51Z",
			"updated_at": "2023-02-25T11:47:51Z",
			"author_association": "CONTRIBUTOR",
			"body": "I've updated the icon, but it still doesn't show. I don't understand why it can happen even after multiple cleans. But still. @laurent22 maybe can you please checkout my branch and test yourself how it looks like?\r\n\r\nAlso, I noticed that the majority of the apps doesn't set the color of the notification, and the system sets color for the notification from the device theme, making all the notification icons look nice. I thus decided to remove the color and check how it will look like, but still with no luck",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445063390/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445389025",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1445389025",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1445389025,
			"node_id": "IC_kwDOBLftOs5WJuLh",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-02-26T15:28:06Z",
			"updated_at": "2023-02-26T15:28:06Z",
			"author_association": "OWNER",
			"body": "Yes it seems to look as expected on emulator:\r\n\r\n<img width=\"350\" alt=\"image\" src=\"https://user-images.githubusercontent.com/1285584/221419974-db7e02eb-567a-41b6-b453-1c89103adf47.png\">\r\n\r\nI guess the last thing would be to implement this on generate-images.ts",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1445389025/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1465225534",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1465225534",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1465225534,
			"node_id": "IC_kwDOBLftOs5XVZE-",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-03-12T15:17:20Z",
			"updated_at": "2023-03-12T15:17:20Z",
			"author_association": "OWNER",
			"body": "@fobo66, are you still interested in completing this PR?",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1465225534/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1465231080",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1465231080",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1465231080,
			"node_id": "IC_kwDOBLftOs5XVabo",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-03-12T15:41:16Z",
			"updated_at": "2023-03-12T15:41:16Z",
			"author_association": "CONTRIBUTOR",
			"body": "Yeah, I'm working on the image generation script",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1465231080/reactions",
				"total_count": 1,
				"+1": 1,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1481923026",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1481923026",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1481923026,
			"node_id": "IC_kwDOBLftOs5YVFnS",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-03-23T21:16:29Z",
			"updated_at": "2023-03-23T21:16:29Z",
			"author_association": "OWNER",
			"body": "@fobo66, is it ready to merge now? It looks good to me. If you could just run `yarn install` to fix the conflict and commit that should do it",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1481923026/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1482466187",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1482466187",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1482466187,
			"node_id": "IC_kwDOBLftOs5YXKOL",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-03-24T09:02:13Z",
			"updated_at": "2023-03-24T09:02:13Z",
			"author_association": "CONTRIBUTOR",
			"body": "Well, not quite ready: for some reason XML resources get corrupted, I'm trying to figure out why. Also, `yarn install` fails and breaks husky, something is not particularly right with it, I suppose",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1482466187/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1482527699",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1482527699",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1482527699,
			"node_id": "IC_kwDOBLftOs5YXZPT",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-03-24T09:50:44Z",
			"updated_at": "2023-03-24T09:50:44Z",
			"author_association": "OWNER",
			"body": "> Also, yarn install fails and breaks husky, something is not particularly right with it, I suppose\r\n\r\nWhat error is it?",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1482527699/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1483144388",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1483144388",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1483144388,
			"node_id": "IC_kwDOBLftOs5YZvzE",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-03-24T17:11:47Z",
			"updated_at": "2023-03-24T17:11:47Z",
			"author_association": "CONTRIBUTOR",
			"body": "I get this error:\r\n\r\n```\r\nInternal Error: @types/q@npm:^1.5.1: This package doesn't seem to be present in your lockfile; run \"yarn install\" to update the lockfile\r\n    at Cb.getCandidates (C:\\Users\\fobo6\\StudioProjects\\joplin\\.yarn\\releases\\yarn-3.3.1.cjs:435:5146)\r\n    at zf.getCandidates (C:\\Users\\fobo6\\StudioProjects\\joplin\\.yarn\\releases\\yarn-3.3.1.cjs:391:1264)\r\n    at C:\\Users\\fobo6\\StudioProjects\\joplin\\.yarn\\releases\\yarn-3.3.1.cjs:439:7695\r\n    at Ff (C:\\Users\\fobo6\\StudioProjects\\joplin\\.yarn\\releases\\yarn-3.3.1.cjs:390:8965)\r\n    at ge (C:\\Users\\fobo6\\StudioProjects\\joplin\\.yarn\\releases\\yarn-3.3.1.cjs:439:7675)\r\n    at async Promise.allSettled (index 0)\r\n    at async eo (C:\\Users\\fobo6\\StudioProjects\\joplin\\.yarn\\releases\\yarn-3.3.1.cjs:390:8293)\r\n```\r\n\r\nAnd `yarn install` doesn't help to resolve it",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1483144388/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1483170602",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1483170602",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1483170602,
			"node_id": "IC_kwDOBLftOs5YZ2Mq",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-03-24T17:31:41Z",
			"updated_at": "2023-03-24T17:31:41Z",
			"author_association": "CONTRIBUTOR",
			"body": "If I remove lock file and run `yarn install`, I get multiple errors with building projects across workspace that seem to originate from dependencies. I've attached the logfile\r\n[build.log](https://github.com/laurent22/joplin/files/11064920/build.log)\r\n",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1483170602/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1483465492",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1483465492",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1483465492,
			"node_id": "IC_kwDOBLftOs5Ya-MU",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-03-24T21:53:18Z",
			"updated_at": "2023-03-24T21:53:18Z",
			"author_association": "OWNER",
			"body": "Ok, then don't worry about yarn.lock, I'll fix it later. There's something off with your env but not sure what. \r\n\r\nRegarding the issue with svg files, isn't it because Sharp doesn't support SVG files? In that case maybe you can keep one input as a PNG so that no conversion is needed?",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1483465492/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1486954970",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1486954970",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1486954970,
			"node_id": "IC_kwDOBLftOs5YoSHa",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-03-28T14:02:29Z",
			"updated_at": "2023-03-28T14:02:29Z",
			"author_association": "CONTRIBUTOR",
			"body": "Sharp seems to handle SVGs fine, PNG images are generated correctly from the SVG source. It's the other tool, svg2vectordrawable, that seems to generate PNG files instead of XML. Although I suspect that Sharp intervenes in the process of generating vector drawable XML for some reason",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1486954970/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1501099059",
			"html_url": "https://github.com/laurent22/joplin/pull/7772#issuecomment-1501099059",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7772",
			"id": 1501099059,
			"node_id": "IC_kwDOBLftOs5ZePQz",
			"user": {
				"login": "fobo66",
				"id": 4471821,
				"node_id": "MDQ6VXNlcjQ0NzE4MjE=",
				"avatar_url": "https://avatars.githubusercontent.com/u/4471821?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/fobo66",
				"html_url": "https://github.com/fobo66",
				"followers_url": "https://api.github.com/users/fobo66/followers",
				"following_url": "https://api.github.com/users/fobo66/following{/other_user}",
				"gists_url": "https://api.github.com/users/fobo66/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/fobo66/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/fobo66/subscriptions",
				"organizations_url": "https://api.github.com/users/fobo66/orgs",
				"repos_url": "https://api.github.com/users/fobo66/repos",
				"events_url": "https://api.github.com/users/fobo66/events{/privacy}",
				"received_events_url": "https://api.github.com/users/fobo66/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-04-09T10:46:37Z",
			"updated_at": "2023-04-09T10:46:37Z",
			"author_association": "CONTRIBUTOR",
			"body": "@laurent22 I believe I fixed the issue, icons are now generated just fine. Needed to resize SVGs in the image sources though, hopefully it will be OK\r\n\r\nI've checked the issue with yarn.lock, and there seems to be the same error on macOS as on Windows, so either I screwed up something with the lockfile or svg2vectordrawable is incompatible with the newer dependencies",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1501099059/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		}
	]
}